Fix ScanConfigs and Policies NVT oid->id

[y0urself]

What:

• Change occurrences of oid in ScanConfigs and Policies to id due to latest changes in Hyperion.

Why:

• changed it in Hyperion

How:

Checklist:

• Tests
• CHANGELOG Entry

[codecov]

Codecov Report

Merging #2733 (8e20fa6) into master (ec81342) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2733      +/-   ##
==========================================
+ Coverage   62.80%   62.82%   +0.01%     
==========================================
  Files        1116     1115       -1     
  Lines       28371    28393      +22     
  Branches     8034     8031       -3     
==========================================
+ Hits        17819    17838      +19     
- Misses       9563     9566       +3     
  Partials      989      989              

Impacted Files	Coverage Δ
gsa/src/web/graphql/policies.js	100.00% <ø> (ø)
gsa/src/web/graphql/scanconfigs.js	100.00% <ø> (ø)
gsa/src/web/pages/scanconfigs/nvtpreferences.js	92.30% <ø> (ø)
gsa/src/gmp/models/policy.js	98.23% <100.00%> (ø)
gsa/src/gmp/models/scanconfig.js	99.24% <100.00%> (ø)
gsa/src/web/pages/scanconfigs/detailspage.js	95.38% <100.00%> (ø)
gsa/src/web/pages/usersettings/validationrules.js	33.33% <0.00%> (-33.34%)	⬇️
gsa/src/web/pages/usersettings/dialog.js	25.00% <0.00%> (-4.42%)	⬇️
gsa/src/web/components/dialog/savedialog.js	65.00% <0.00%> (-1.67%)	⬇️
gsa/src/web/components/form/useFormValidation.js	97.61% <0.00%> (ø)
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec81342...6d3100c. Read the comment docs.

[bjoernricks]

The whole preference handling in the models (scan configs and policies) looks a bit weird now. IMHO this should be refactored and maybe some parts can also be moved to hyperion already. For example the differentiation between scanner and nvt preferences should be done in the backend already and copying the original nvt should be necessary anymore.

          const nvt = {...pref.nvt};
          pref.nvt = nvt;
          pref.nvt.id = preference.nvt.id;

makes no sense to me.