Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report detailspage tests #2722

Merged

Conversation

sarahd93
Copy link
Contributor

What:
Add tests for report detailspage.

Why:
The page does not have tests yet and we need them before we can start refactoring.

How:

Checklist:

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #2722 (0c1e035) into master (40839e6) will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2722      +/-   ##
==========================================
+ Coverage   62.20%   62.82%   +0.62%     
==========================================
  Files        1115     1115              
  Lines       28393    28395       +2     
  Branches     8031     8031              
==========================================
+ Hits        17662    17840     +178     
+ Misses       9728     9566     -162     
+ Partials     1003      989      -14     
Impacted Files Coverage Δ
gsa/src/web/components/tab/tab.js 95.23% <ø> (ø)
gsa/src/gmp/models/note.js 100.00% <0.00%> (ø)
gsa/src/web/components/powerfilter/powerfilter.js 58.82% <0.00%> (+2.35%) ⬆️
gsa/src/web/store/entities/reports.js 100.00% <0.00%> (+21.05%) ⬆️
gsa/src/web/pages/reports/detailscontent.js 78.31% <0.00%> (+27.71%) ⬆️
gsa/src/web/pages/reports/detailspage.js 61.92% <0.00%> (+56.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40839e6...03c1c38. Read the comment docs.

@sarahd93 sarahd93 force-pushed the report_detailspage_tests_master branch from 0c1e035 to 1627c3d Compare February 12, 2021 14:42
@sarahd93 sarahd93 marked this pull request as ready for review February 12, 2021 15:41
@sarahd93 sarahd93 requested review from a team and bjoernricks February 12, 2021 15:41
@bjoernricks bjoernricks merged commit c802980 into greenbone:master Feb 15, 2021
@sarahd93 sarahd93 deleted the report_detailspage_tests_master branch February 16, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants