Merge pull request #4338 from greenbone/fix-svg-console-errors

cleanup svg console errors
greenbone · Feb 17, 2025 · 75a6e89 · 75a6e89
2 parents 4e8778a + b0ad06a
commit 75a6e89
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/src/web/components/icon/SvgIconWrapper.jsx b/src/web/components/icon/SvgIconWrapper.jsx
@@ -14,10 +14,10 @@ const SvgIconWrapper = ({component: Component, size, ...props}) => (
 );
 
 SvgIconWrapper.propTypes = {
-  component: PropTypes.node.isRequired,
+  component: PropTypes.elementType.isRequired,
   size: PropTypes.oneOfType([
     PropTypes.oneOf(['tiny', 'small', 'medium', 'large']),
-    PropTypes.string,
+    PropTypes.arrayOf(PropTypes.string),
   ]),
 };
 

diff --git a/src/web/components/icon/svgicon.jsx b/src/web/components/icon/svgicon.jsx
@@ -99,7 +99,7 @@ const SvgIcon = ({
 
     if (isDefined(promise) && isDefined(promise.then)) {
       setLoading(true);
-       
+
       promise
         .then(() => {
           setLoading(false);
@@ -137,7 +137,11 @@ const SvgIcon = ({
 };
 
 SvgIcon.propTypes = {
-  children: PropTypes.func.isRequired,
+  children: PropTypes.oneOfType([
+    PropTypes.arrayOf(PropTypes.node),
+    PropTypes.node,
+    PropTypes.func,
+  ]),
   color: PropTypes.string,
   active: PropTypes.bool,
   disabled: PropTypes.bool,
@@ -146,7 +150,10 @@ SvgIcon.propTypes = {
   to: PropTypes.string,
   value: PropTypes.any,
   onClick: PropTypes.func,
-  size: PropTypes.oneOf(['tiny', 'small', 'medium', 'large']),
+  size: PropTypes.oneOfType([
+    PropTypes.oneOf(['tiny', 'small', 'medium', 'large']),
+    PropTypes.arrayOf(PropTypes.string),
+  ]),
 };
 
 export default SvgIcon;
diff --git a/src/web/utils/proptypes.jsx b/src/web/utils/proptypes.jsx
@@ -215,6 +215,7 @@ const gsaPropTypes = {
   shape: ReactPropTypes.shape,
   symbol: ReactPropTypes.symbol,
   string: ReactPropTypes.string,
+  elementType: ReactPropTypes.elementType,
 
   capabilities,
   counts,