Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function declaration #135

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fix function declaration #135

merged 1 commit into from
Jan 17, 2019

Conversation

kitayoshi
Copy link
Contributor

greena13
greena13 approved these changes Jan 17, 2019
View reviewed changes
Copy link
Owner

@greena13 greena13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

@greena13 greena13 merged commit a5a9b79 into greena13:master Jan 17, 2019
@kitayoshi
Copy link
Contributor Author

kitayoshi commented Jan 21, 2019 •
edited
Loading

Hi @greena13, thanks for your approving! Could you please release a pre version including this commit and #137? I don't want to fork a declaration, thanks again~

@greena13
Copy link
Owner

Hi midare, apologies for the delay.

The next pre-release is now available (v2.0.0-pre4) and it includes your fixes the typescript definitions (and others').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greena13 greena13 greena13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitayoshi @greena13