Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds-ping-on-install #1067

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adds-ping-on-install #1067

wants to merge 2 commits into from

Conversation

ribalba
Copy link
Member

@ribalba ribalba commented Jan 31, 2025

Will fix the tests and and add some once we have agreed that this is the way we want to implement this.

I could also imagine that we do it on a per run basis. That would be more interesting data but privacy should be paramount here.

@ribalba ribalba requested a review from ArneTR January 31, 2025 09:40
@ArneTR
Copy link
Member

ArneTR commented Jan 31, 2025

Looks like a good and compact implementation.

I am however not in favor of having the receiver end inside of the GMT. It is not a lot of code, but is has nothing to do there. In a worst case scenario people use it to flood other installations with bogus information because it is a an all-receiving endpoint.

Happy to merge this in when the tests work. Please just send the data to the same endpoint from Plausible as EE does it. We should install a CNAME soon to have this analytics vendor agnostic

@ArneTR
Copy link
Member

ArneTR commented Feb 7, 2025

I installed a CNAME

hello.green-coding.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants