EC72 Java Example Code #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EC72 example compliant code doesn't compile and breaks other SonarQube rules that prevent introducing vulnerability to SQL Injection. This example complaint code conforms to other SonarQube rules, correctly compiles and still results in the efficiency saving that the rule is intended to give.
…CoE/EC72-Java-Fix Update EC72 Example Code
|
Hi @dedece35, is there anything I've missed? This is my first OS contribution, so hoping I've followed the process correctly. |
|
Hi @lbg-pete, |
dedece35
added
🚀 enhancement
|
@dedece35 - Conflicts resolved. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EC72 example Java compliant code doesn't compile and breaks other SonarQube rules that would prevent introducing a vulnerability to SQL Injection.
This suggested contribution, if you agree, reworks the example complaint code so that it correctly compiles, conforms to other SonarQube rules and still results in the energy efficiency saving that the rule is intended to give.