Java - Rules "Avoid returning a JPA Entity in a RestController"

[MP-Aubay]

Team : 2 millions

Rule ID incoming (green-code-initiative/creedengo-challenge#58)

Rule description :
Using persistence Entity in the return of a Rest controler is not energy efficient.
This use induces a multiples unnecessary SQL calls, multiple unused fields serialization, and thus unnecessary calculations by the CPU, RAM usage and network usage.

[natixis-caen]

typo: parameterized is missing an e

[MP-Aubay]

thx fixed

[rducasse]

Also replaced the methods.get(0) by methodTree

[MP-Aubay]

This feature should not be merge before final rule ID is know and updated in code

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

96.9% Coverage
0.0% Duplication

[SebastienSurier]

For now, can we just add a ruleID with a number not already used and add the rule un rules.md file ?
If necessary, we can redo a small refacto to change the naming, when a rule is well defined

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

Hi @MP-Aubay @rducasse
please resolve conflict and then check DoD list here https://github.com/green-code-initiative/ecoCode-common/blob/main/doc/starter-pack.md#definition-of-done-of-a-pr

[github-actions]

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

[dedece35]

to discuss in core-team :

• no scientific paper to prove this rule
• no measures to prove it's a "green" rule

for me, rule not acceptable like that.
do we refuse this rule ?

[jhertout]

Hello,

I agree that we don't have enough elements to validate and add this rule in the plugin.

[dedece35]

Hi @MP-Aubay, @natixis-caen, @SebastienSurier, @rducasse

sorry but with implementation is that situation, we can't accept this implementation because :

• no scientific paper to prove this rule
• no measures to prove it's a "green" rule

We keep this proposition to measure it when we will have a tool to measure it.
(check RULES.md )