-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRDOM203] [Html] HTML page must contain a doctype tag #103
Comments
Hello! I think that this rule is more related to HTML than PHP, no? |
Does this issue is covered by this existing sonar rule : https://rules.sonarsource.com/html/RSPEC-1095 ? |
Yes, th'ats we have actually present in conference. Have to PR ecocode-common if i havent already did it. Will do next.. |
This is done here |
I try to add a reference/validation to this doctype rule. The Kanban ticket is lacking info: only "CPU consumption" Is it a fact? I have checked differents infos... without being convinced. Thanks for your help
|
TO DISCUSS INSIDE CORE-TEAM : ok to merge associated PR ? (only add ecocode tag to existing SonarQube rule "Web:DoctypePresenceCheck") |
This is an interesting idea, especially since this rule is essential in HTML5. So the starting point is to know if Quirks mode (which is activated when the doctype is not defined) is more resource intensive than standard mode. Although I don't know exactly how browser rendering engines work, I am also unconvinced by the direct link with ecodesign. Experts seem to say that the difference in performance is negligible. The main objective of the DOCTYPE is to tell the browser to support all standard features and not stick with old ones (this is also why the rule on the SonarQube side is typed "user-experience"). BUT it is entirely possible that some of these standard features will increase page performance. If we type the rule as "eco-design", we risk getting a lot of feedback asking us why it is typed that way. And without a concrete article explaining that Quirks mode is more resource-intensive (supporting proof), it seems complicated to argue.. I would be in favor of not typing it as "eco-design". For now. References: |
After several tests, research, and given my comment #103 (comment) this rule doesn't seem to be eco-design as it stands. So I propose to close this ticket. |
Team 5R
The text was updated successfully, but these errors were encountered: