Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/contract executions refactor #61

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

BurntVal
Copy link
Contributor

Description

This PR aims to fix an oversight in our initial PR, where we implemented smart contracts hooks (namely useExecuteContract). We didn't pass the funds and memo params to the execute call, leading to errors in production case where those params are needed.

Checklist

  • I have made sure the upstream branch for this PR is correct
  • I have made sure this PR is ready to merge
  • I have made sure that I have assigned reviewers related to this project

Changes

  • Added fields to ExecuteContractArgs & ExecuteContractMutationArgs interface, and passed appropriately to execute call
  • Changed ...
  • Removed ...

Testing

Create an execute msg for the returned executeContract function from the useExecuteContract hook, now with the ability to add "funds" and "memo" fields

@vercel vercel bot temporarily deployed to Preview – graz-example February 24, 2023 20:34 Inactive
Copy link
Member

@codingki codingki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! we didn't catch those params before. Thanks @BurntVal

@vercel vercel bot temporarily deployed to Preview – graz-docs February 24, 2023 20:35 Inactive
@codingki codingki merged commit 2362a84 into graz-sh:dev Feb 24, 2023
@BurntVal
Copy link
Contributor Author

Wow. Thank you for such a quick response. Always a pleasure working with you guys @codingki @grikomsn ! 😄

@codingki
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants