Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UITableViewDelegate implementation #9

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Fix UITableViewDelegate implementation #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fcfe6
Fix UITableViewDelegate implementation
graycampbell Oct 6, 2017
c7c6331
Bump version number
graycampbell Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions GCCountryPicker.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
Pod::Spec.new do |s|
s.name = 'GCCountryPicker'
s.version = '1.0.1'
s.version = '1.0.2'
s.license = { :type => 'MIT', :file => 'LICENSE' }
s.summary = 'A searchable country picker view controller for iOS 11+ written in Swift.'
s.summary = 'A localized, searchable country picker view controller for iOS 11+ written in Swift.'
s.description = <<-DESC
A searchable country picker view controller UI component for iOS 11+ written in Swift.
A localized, searchable country picker view controller UI component for iOS 11+ written in Swift.
DESC
s.homepage = 'https://github.com/graycampbell/GCCountryPicker'
s.author = 'Gray Campbell'
Expand Down
13 changes: 13 additions & 0 deletions GCCountryPicker/GCCountryPickerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,19 @@ extension GCCountryPickerViewController {

extension GCCountryPickerViewController {

/// Asks the delegate for the height to use for the header of a particular section.
///
/// This method allows the delegate to specify section headers with varying heights.
///
/// - Parameter tableView: The table-view object requesting this information.
/// - Parameter section: An index number identifying a section of tableView.
/// - Returns: A nonnegative floating-point value that specifies the height (in points) of the header for section.

public override func tableView(_ tableView: UITableView, heightForHeaderInSection section: Int) -> CGFloat {

return 28
}

/// Asks the delegate for a view object to display in the header of the specified section of the table view.
///
/// The returned object can be a UILabel or UIImageView object, as well as a custom view. This method only works correctly when tableView(_:heightForHeaderInSection:) is also implemented.
Expand Down
2 changes: 1 addition & 1 deletion GCCountryPicker/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>1.0.1</string>
<string>1.0.2</string>
<key>CFBundleVersion</key>
<string>$(CURRENT_PROJECT_VERSION)</string>
<key>NSPrincipalClass</key>
Expand Down
2 changes: 1 addition & 1 deletion GCCountryPickerDemo/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.0.1</string>
<string>1.0.2</string>
<key>CFBundleVersion</key>
<string>1.0</string>
<key>LSRequiresIPhoneOS</key>
Expand Down
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@ pod 'GCCountryPicker'
### Documentation
- [Classes](http://cocoadocs.org/docsets/GCCountryPicker/1.0.0/Classes.html)
- [GCCountry](http://cocoadocs.org/docsets/GCCountryPicker/1.0.0/Classes/GCCountry.html)
- [GCCountryPickerViewController](http://cocoadocs.org/docsets/GCCountryPicker/1.0.0/Classes/GCCountryPickerViewController.html)
- [Classes](http://cocoadocs.org/docsets/GCCountryPicker/1.0.2/Classes.html)
- [GCCountry](http://cocoadocs.org/docsets/GCCountryPicker/1.0.2/Classes/GCCountry.html)
- [GCCountryPickerViewController](http://cocoadocs.org/docsets/GCCountryPicker/1.0.2/Classes/GCCountryPickerViewController.html)
- [Protocols](http://cocoadocs.org/docsets/GCCountryPicker/1.0.0/Protocols.html)
- [GCCountryPickerDelegate](http://cocoadocs.org/docsets/GCCountryPicker/1.0.0/Protocols/GCCountryPickerDelegate.html)
- [GCCountryPickerDataSource](http://cocoadocs.org/docsets/GCCountryPicker/1.0.0/Protocols/GCCountryPickerDataSource.html)
- [Protocols](http://cocoadocs.org/docsets/GCCountryPicker/1.0.2/Protocols.html)
- [GCCountryPickerDelegate](http://cocoadocs.org/docsets/GCCountryPicker/1.0.2/Protocols/GCCountryPickerDelegate.html)
- [GCCountryPickerDataSource](http://cocoadocs.org/docsets/GCCountryPicker/1.0.2/Protocols/GCCountryPickerDataSource.html)
### License
Expand Down