Skip to content

Commit

Permalink
Merge pull request #8 from graycampbell/demo-localization
Browse files Browse the repository at this point in the history
 Add banner and demo localization
  • Loading branch information
graycampbell authored Oct 5, 2017
2 parents 42a165e + 57ae611 commit 504ab69
Show file tree
Hide file tree
Showing 14 changed files with 65 additions and 1 deletion.
23 changes: 23 additions & 0 deletions GCCountryPickerDemo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
E2644B5A1F7D93260034EA06 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = E2644B591F7D93260034EA06 /* Assets.xcassets */; };
E2644B5D1F7D93260034EA06 /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = E2644B5B1F7D93260034EA06 /* LaunchScreen.storyboard */; };
E2F9BFAF1F7D962200131AF8 /* GCCountryPicker.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E2644B661F7D93450034EA06 /* GCCountryPicker.framework */; };
E2FDD8481F86C27200C1595A /* Localizable.strings in Resources */ = {isa = PBXBuildFile; fileRef = E2FDD84A1F86C27200C1595A /* Localizable.strings */; };
/* End PBXBuildFile section */

/* Begin PBXFileReference section */
Expand All @@ -24,6 +25,10 @@
E2644B5C1F7D93260034EA06 /* Base */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; name = Base; path = Base.lproj/LaunchScreen.storyboard; sourceTree = "<group>"; };
E2644B5E1F7D93260034EA06 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
E2644B661F7D93450034EA06 /* GCCountryPicker.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = GCCountryPicker.framework; sourceTree = BUILT_PRODUCTS_DIR; };
E2FDD8491F86C27200C1595A /* en */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = en; path = en.lproj/Localizable.strings; sourceTree = "<group>"; };
E2FDD84B1F86C2A400C1595A /* zh-Hans */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = "zh-Hans"; path = "zh-Hans.lproj/Localizable.strings"; sourceTree = "<group>"; };
E2FDD84D1F86C32800C1595A /* de */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = de; path = de.lproj/Localizable.strings; sourceTree = "<group>"; };
E2FDD84E1F86C33B00C1595A /* ja */ = {isa = PBXFileReference; lastKnownFileType = text.plist.strings; name = ja; path = ja.lproj/Localizable.strings; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFrameworksBuildPhase section */
Expand Down Expand Up @@ -63,6 +68,7 @@
E2644B591F7D93260034EA06 /* Assets.xcassets */,
E2644B561F7D93260034EA06 /* Main.storyboard */,
E2644B5B1F7D93260034EA06 /* LaunchScreen.storyboard */,
E2FDD84A1F86C27200C1595A /* Localizable.strings */,
E2644B5E1F7D93260034EA06 /* Info.plist */,
);
path = GCCountryPickerDemo;
Expand Down Expand Up @@ -119,6 +125,9 @@
knownRegions = (
en,
Base,
"zh-Hans",
de,
ja,
);
mainGroup = E2644B461F7D93260034EA06;
productRefGroup = E2644B501F7D93260034EA06 /* Products */;
Expand All @@ -136,6 +145,7 @@
buildActionMask = 2147483647;
files = (
E2644B5D1F7D93260034EA06 /* LaunchScreen.storyboard in Resources */,
E2FDD8481F86C27200C1595A /* Localizable.strings in Resources */,
E2644B5A1F7D93260034EA06 /* Assets.xcassets in Resources */,
E2644B581F7D93260034EA06 /* Main.storyboard in Resources */,
);
Expand Down Expand Up @@ -172,13 +182,25 @@
name = LaunchScreen.storyboard;
sourceTree = "<group>";
};
E2FDD84A1F86C27200C1595A /* Localizable.strings */ = {
isa = PBXVariantGroup;
children = (
E2FDD8491F86C27200C1595A /* en */,
E2FDD84B1F86C2A400C1595A /* zh-Hans */,
E2FDD84D1F86C32800C1595A /* de */,
E2FDD84E1F86C33B00C1595A /* ja */,
);
name = Localizable.strings;
sourceTree = "<group>";
};
/* End PBXVariantGroup section */

/* Begin XCBuildConfiguration section */
E2644B5F1F7D93260034EA06 /* Debug */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
Expand Down Expand Up @@ -236,6 +258,7 @@
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_ANALYZER_NONNULL = YES;
CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
Expand Down
2 changes: 1 addition & 1 deletion GCCountryPickerDemo/ViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ extension ViewController {
let countryPickerViewController = GCCountryPickerViewController()

countryPickerViewController.delegate = self
countryPickerViewController.navigationItem.title = "Countries"
countryPickerViewController.navigationItem.title = NSLocalizedString("Countries", comment: "")

let navigationController = UINavigationController(rootViewController: countryPickerViewController)

Expand Down
8 changes: 8 additions & 0 deletions GCCountryPickerDemo/de.lproj/Localizable.strings
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//
// Localizable.strings
// GCCountryPickerDemo
//
// Created by Gray Campbell on 10/5/17.
//

Countries = "Länder";
8 changes: 8 additions & 0 deletions GCCountryPickerDemo/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//
// Localizable.strings
// GCCountryPickerDemo
//
// Created by Gray Campbell on 10/5/17.
//

Countries = "Countries";
7 changes: 7 additions & 0 deletions GCCountryPickerDemo/fr.lproj/Localizable.strings
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
/*
Localizable.strings
GCCountryPickerDemo

Created by MacBook Pro on 10/5/17.
Copyright © 2017 Gray Campbell. All rights reserved.
*/
8 changes: 8 additions & 0 deletions GCCountryPickerDemo/ja.lproj/Localizable.strings
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//
// Localizable.strings
// GCCountryPickerDemo
//
// Created by Gray Campbell on 10/5/17.
//

Countries = "国々";
8 changes: 8 additions & 0 deletions GCCountryPickerDemo/zh-Hans.lproj/Localizable.strings
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
//
// Localizable.strings
// GCCountryPickerDemo
//
// Created by Gray Campbell on 10/5/17.
//

Countries = "国家";
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
![banner](Resources/README/Assets/Banner.png)

[![Release](https://img.shields.io/github/release/graycampbell/GCCountryPicker.svg)](https://github.com/graycampbell/GCCountryPicker/releases/latest)
[![CocoaPods](https://img.shields.io/cocoapods/v/GCCountryPicker.svg)](https://cocoapods.org/pods/GCCountryPicker)
[![CocoaDocs](https://img.shields.io/cocoapods/metrics/doc-percent/GCCountryPicker.svg)](http://cocoadocs.org/docsets/GCCountryPicker)
Expand Down
Binary file added Resources/README/Assets/Banner.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified Resources/README/Projects/Banner.sketch
Binary file not shown.
Binary file added Resources/README/Screenshots/de.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Resources/README/Screenshots/en.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Resources/README/Screenshots/ja.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Resources/README/Screenshots/zh-Hans.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 504ab69

Please sign in to comment.