Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated preferences documentation #1377

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

ashnwade
Copy link
Collaborator

This PR addresses #1327 and also makes some changes to reflect changes that have been made to the tabs since CBAC and MFA were introduced. This needed some updating.

Copy link
Contributor

@michael-wisely-gravwell michael-wisely-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes LGTM!

I think clarifying to "granted capabilities" is a good idea. Let's do that, then I think this PR is ready to go.

Copy link
Contributor

@michael-wisely-gravwell michael-wisely-gravwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-wisely-gravwell michael-wisely-gravwell merged commit f0401cc into gravwell:next-minor Jan 29, 2025
1 check passed
@ashnwade ashnwade deleted the 24h-preferences branch February 5, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants