Update eval language around conditional comparison again #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-fritz-gravwell
requested review from
ashnwade,
kris-watts-gravwell and
john-floren-gravwell
kris-watts-gravwell
requested changes
Nov 8, 2024
There was a problem hiding this comment.
I think we need to explicitly define what a type check is and provide an example. Most people have no idea what "a type check" is.
And realistically they shouldn't be doing type checks. They should be doing type casts and building effective comparisons where a type casts failure still behaves correctly
john-floren-gravwell
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.