gw-limit-multiselect.js: Fixed an issue with limit multi-select not working with GP Advanced Select.
#687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… working with GP Advanced Select.
Comment on lines
63
to
+71
| .find( 'option:not(:checked)' ) | ||
| .prop( 'disabled', selectedCount >= max ) | ||
| .trigger( 'chosen:updated' ); | ||
|
|
||
| // For Tom Select (GP Advanced Select) | ||
| // Update "1" to the ID of your Multi Select field. | ||
| if ( $( '#input_GFFORMID_1-ts-dropdown' ) ) { | ||
| $( '#input_GFFORMID_1-ts-dropdown .option' ).removeAttr( 'data-selectable' ); | ||
| } |
There was a problem hiding this comment.
Curious, if you unselect choices (to get below the max), do the disabled choices get re-enabled?
This snippet reads like even without Tom Select, they'd stay disabled.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2301130622/52247/
Summary
Add support for Tom Select (GP Advanced Select) to work with the Limit Multi-Select snippet.
After the update, standard behaviour (without GPAS) still works fine:
https://www.loom.com/share/a8bbd3644f074653a756523d99541c5a
After the update, the behaviour with GPAS is fixed:
https://www.loom.com/share/8d6463d62cfe47d8884783e1471d3a77