Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to work with pyscopg2 version 2.9.1 #4451

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

frankdean
Copy link
Contributor

Fixes #4447

Tested against psycopg2 versions 2.8.6 and 2.9.1

The calls to self._conn.commit() should be superfluous in version 2.9.1 of psycopg2 but are still needed in older versions.

Fixes gravitystorm#4447

Tested against psycopg2 versions 2.8.6 and 2.9.1
@pnorman pnorman self-requested a review August 29, 2021 22:44
Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested on 2.8

@pnorman pnorman merged commit 4ec2dc9 into gravitystorm:master Aug 29, 2021
@frankdean frankdean deleted the fix-get-external-data branch August 30, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scripts/get-external-data.py does not work with psycopg2 2.9.1
2 participants