Remove rendering of natural=marsh #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With that change I'd like to ask if there would be any downsides to changing all Also yes I like your proposal since the tag is deprecated |
|
You may certainly edit any features in your local area which you can confirm to be marshes. If you want to semi-automatically change a large number of features, see this warning: |
|
👍 in principle, haven't reviewed the code. |
jeisenbe
added a commit
to jeisenbe/openstreetmap-carto
that referenced
this pull request
Oct 4, 2019
The rendering for natural=marsh was already removed in PR gravitystorm#3829, so these lines are unused.
jeisenbe
added a commit
that referenced
this pull request
Oct 23, 2019
The rendering for natural=marsh was already removed in PR #3829, so these lines are unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3797
Changes proposed in this pull request:
Explanation:
Currently
natural=marshis rendered, however, the correct tagging for a marsh isnatural=wetland+wetland=marshas with other types of wetland. These two options are currently both rendered identicallyAccording to the wiki,
natural=marshhas not been recommended since January 2009 or earlier, and the page has specified that this tag is deprecated since 2016.Since 2009,
wetland=marshhas shown steadily increasing usage. It is now used 135,000 times, compared to 9000 remaining uses ofnatural=marsh:Test rendering with links to the example places:
https://www.openstreetmap.org/#map=16/51.2726/-0.7962
Before
After
