Restore height and ele text #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to be done by processing in the subselects and the outer selects, now it's done in just the outer.
imagico
approved these changes
May 6, 2019
There was a problem hiding this comment.
Looks fine and test fine.
I noticed that apparently with this change this:
https://www.openstreetmap.org/way/70833186
is rendered with an elevation label while in 4.20.0 it is not. That is not a problem IMO and i have not tracked down what exactly is the reason for the difference but wanted to mention it none the less.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be done by processing in the subselects and the outer selects, now it's done in just the outer.
Fixes #3765