-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render landuse with grass color from z5 instead of z10 #3701
Conversation
+1 👍
|
Looks good to me. Some colors, like grass/forest, are hard to distinguish, but that's not the fault of this pull request. |
I’m actually surprised that these areas are mapped as landuse=grass instead
of landuse=meadow but perhaps this better translates the word used in Dutch?
|
From what I remember with early discussions landuse=grass is one of those tags that's a little vague, over mapped in places where it probably shouldn't be due to that, and should probably be surface tag instead. More then likely in this case its over applied because managed nature of it. So landuse=meadow would probably be better, but there's still lots of other instances where rendering grass at z5 would be beneficial. Maybe even this one so people will see it and re-tag it properly if need be. |
I don't actually see a good reason for any starting zoom level differentiation here for features that are otherwise rendered identically at all zoom levels. This is unexpected and confusing for mappers. So the same should IMO be done for |
I'm also surprised there are such large areas of landuse=grass, when this is intented for small managed patches of grass in residential/highway-side areas. Shouldn't the large country-side areas be natural=grassland or landuse=meadow or even landuse=farmland (if the grass is seeded to be farmed later). |
@vholten - i would prefer to remove all differentiation in starting zoom levels between different grass color tags, i.e. also for landuse=village_green. If you can change that i would merge this. |
@imagico That sounds good, I'll probably do it this weekend. |
PR updated: landuse=village_green is now also rendered from z5 instead of z10. I couldn't find any village_green areas that are large enough to be visible below z10 however. @imagico Do you also want leisure=garden rendered from z5? It has a grass color and is currently rendered from z10. |
Thanks. leisure=garden is a somewhat different matter since that is differentiated in rendering at higher zoom levels. |
Fixes #3696
Change proposed in this pull request:
This allows large grassy areas, such as in the Netherlands, to be visible at low zoom.
https://www.openstreetmap.org/#map=9/52.0322/4.7873
z9 before
z9 after
https://www.openstreetmap.org/#map=8/52.0322/4.7873
z8 before
z8 after