Show big states labels #3496
Merged
Show big states labels #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deployed and Z0-6 rerendered. |
|
Thanks! It looks OK, the link to compare is here: http://bl.ocks.org/matthijsmelissen/raw/af7a602c222dbf1ff1a2c0d84ed755b7/#5.00/64.405/-141.584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3353.
There are limits in the code for showing state labels that hide them if the area on the screen is big enough. However some huge states (further inflated by Web Mercator projection) are too big from the start, so their labels are never shown. This occurs with countries on the north, like Russia, Canada and USA (Alaska).
Removing this limit on z5 and z6 makes some cities start being visible along the state name. For Alaska it does not help, because capital is on far south and renders from z7, but at least the name of the state is shown on more than one level.
Testing on filtered subset of the planet file (
osmium tags-filter -o planet-admin-2-4.osm.pbf planet-latest.osm.pbf admin_level=2 admin_level=4), so any objects other than admin data are not shown. @rrzefox could you apply this patch on your server, just in case?Examples: