Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve installation docs #3010

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Improve installation docs #3010

merged 2 commits into from
Jan 10, 2018

Conversation

matkoniecz
Copy link
Contributor

No description provided.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 10, 2018

Looks like CartoCSS won't be needed for deployment if we resolve #3012.

@SomeoneElseOSM
Copy link
Contributor

Looks like CartoCSS won't be needed for deployment if we resolve #3012.

While distributing the compiled XML would be useful to many people (myself included) given the dog's breakfast that is node.js, it should still be a goal to explain to people how to actually produce it, and be the default in any installation instructions.

If you don't you'll get lots of people trying to modify the resultant .xml file (and lots of swearing).

Also don't forget that the project.mml file hardcodes the database name as "gis". This works for many people but it's also pretty common to need to change it too.

Finally if someone needs to understand "why feature X is displayed as it is" it's useful to have the source around to look at.

@kocio-pl
Copy link
Collaborator

Thanks, probably this code can be merged now and solving #3012 should bring further changes to the INSTALL.md.

@matkoniecz
Copy link
Contributor Author

probably this code can be merged now and solving #3012 should bring further changes to the INSTALL.md.

Yes, I prefer to improve documentation of a current state (especially as I am now in situation that I no longer remember some things so it is much easier to spot what is missing/confusing)

@kocio-pl kocio-pl merged commit 8967ae4 into gravitystorm:master Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants