add amenity=charging_station icon

[davidfg4]

Addresses #989 and #108

http://wiki.openstreetmap.org/wiki/Tag:amenity%3Dcharging_station
This adds an icon for amenity=charging_station. If there is a name it should also be rendered, although very few charging stations have a name tag. The icon was taken from https://github.com/gmgeo/osmic per @nebulon42 's suggestion.
There are currently over 8000 charging_station points, and it would be good to be able to view them on the map. See http://overpass-turbo.eu/s/hr4 for where these are currently.

17:

18:

19:

[pnorman]

The icon fits in and the PR looks technically okay, but we never decided in #989 if we want to render charging stations or not. Having the PR lets us see how it looks.

[kocio-pl]

I don't have an opinion if we should render it or not, but the internal part of the icon (spark) is not clear to me on all these exports - could it be wider a bit?

[davidfg4]

Original, wider:

I think the original has better proportions and is clear enough, but the wider lightning bolt is a bit easier to see. I'd be happy to switch it over if a few people would like.

[kocio-pl]

I like wider more, but I think spark could be longer on top (not truncated like it is now).

[davidfg4]

Original, wider, taller:

[kocio-pl]

With wider and taller version the sparks are perfectly recognizable for me now, but I think they could be placed a bit lower.

[davidfg4]

With that version the bolt is two pixels from the top and three from the bottom. It would look weird below center.

[kocio-pl]

I don't think it would, but don't care that much for this detail - it's already an improvement to me.

[dieterdreist]

sent from a phone

Il giorno 22 lug 2016, alle ore 15:14, David Gianforte notifications@github.com ha scritto:

I think the original has better proportions and is clear enough, but the wider lightning bolt is a bit easier to see. I'd be happy to switch it over if a few people would like.

I think wider is better recognizable, maybe you could even try to get rid of the pump and just keep the jack and the bolt (bolt in blue and slightly bigger in this case)

[sorcrosc]

I think wider is better recognizable, maybe you could even try to get rid of the pump and just keep the jack and the bolt (bolt in blue and slightly bigger in this case)

Another way could be to get rid of the bolt and give more focus to the plug?

[davidfg4]

I agree, the wider/taller bolt is easier to see.

The icon we have for fuel has a pump and gas hose, so it'd be nice if the electric charging icon was "similar but different". Looking around the internet I'm seeing similar lightning bolt on a "pump" with cord and plug design that was used in this icon. So it seems to be fairly standard and it would be good to stick with that.

It'd be nice to avoid the "bike shed effect", but if any of you want to explore other ideas feel free to mock them up so we can see.

[sorcrosc]

Sorry, it's my last post. The icon is good and I don't know if it could be better but just to explain.
I agree it should be similar to the fuel pump but the characteristic shape for which the pump is recognizable is already lost, instead it gained two simbols (the bolt and the plug) none of which is so visible

[Barthwo]

I would propose an icon with a bigger plug, which is already in use in this POI map: http://www.flosm.de/html/POI-Karte.html#269265.97/49.4232406/6.96490407/0/chargingcar/chargingstation and also used by Osmand: https://github.com/osmandapp/OsmAnd-resources/blob/master/icons/svg/transport/charging_station.svg
In addition instead of the "name" or if no name is given the "operator" could be used, which is important for the user.

[morray]

should be added and the bolt symbol is good enough at the moment and should not stop it

[matthijsmelissen]

the PR looks technically okay

Are you sure the icon is pixel-aligned? It looks a bit blurry to me.

[matthijsmelissen]

Merged, thanks @davidfg4.

Problems with the icon, if any, could be fixed in a follow-up PR.

[davidfg4]

Thanks @math1985.

It is aligned to pixels, but in order to differentiate between the cable the the prongs, the cable is a bit thicker than 1px, and the prongs are slightly less. Again, I didn't design this, it's from https://github.com/gmgeo/osmic

[kocio-pl]

Am I right that merged version is the same as original (not wider and taller)?

[davidfg4]

@kocio-pl yes

[kocio-pl]

I thought this:

I agree, the wider/taller bolt is easier to see.

meant you wanted to replace the original with it. Do you really want to do that (and haven't done it yet) or I misunderstood you and you want to stick with it?

[davidfg4]

I'm perfectly happy with the original icon too, so at this point I'm not going to make a new PR to change it.

[kocio-pl]

I'd like to make some mockups and PR then. Could you share the link to the SVG version?

I'm against bikesheding and also like to use osmic if possible, but I prefer readability over pureness.

[davidfg4]

Sure, here is the larger bolt: http://gianforte.org/charging_station_LARGER_BOLT.16.svg