Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for toll_booth #958

Closed
HolgerJeromin opened this issue Sep 17, 2014 · 34 comments
Closed

Add rendering for toll_booth #958

HolgerJeromin opened this issue Sep 17, 2014 · 34 comments

Comments

@HolgerJeromin
Copy link
Contributor

I am on mobile so i am not 100% sure it is missing (or there is an issue about it) but rendering barrier=toll_booth would be nice.

Osmand renders it same as a lift gate plus an $

@matthijsmelissen
Copy link
Collaborator

See also #846.

@matthijsmelissen matthijsmelissen changed the title Please render toll_booth Add rendering for toll_booth Sep 26, 2014
@sommerluk
Copy link
Collaborator

Or maybe an icon based on the toll road sign http://upload.wikimedia.org/wikipedia/commons/6/64/BAB-Grenze.svg ?

@matthijsmelissen
Copy link
Collaborator

That's not a toll road sign but a border control sign.

@matkoniecz
Copy link
Contributor

Maybe rendering it like barrier=lift_gate would be OK?

@pnorman
Copy link
Collaborator

pnorman commented Aug 26, 2015

Given we're not rendering toll roads, which are generally considered more important, I'd rather not render the booths.

@polarbearing
Copy link
Contributor

barrier=lift_gate alone would be a bit confusing, since they are a common feature of private parking which belongs on membership and not simple payment. Further, toll is nowadays often collected flee-flow without the physical barrier.

I'd rather follow @pnorman and neither render booths nor roads (#593).

@pnorman
Copy link
Collaborator

pnorman commented Aug 26, 2015

Closing - if we ever figure out a way to render tolls on roads, we can reconsider it.

@pnorman pnorman closed this as completed Aug 26, 2015
@kocio-pl
Copy link
Collaborator

Maybe some kind of tickets or car near the wall or car under the lift gate (in transportation blue, I guess)?

@dieterdreist
Copy link

in Italy most motorways are toll roads. The toll booths are significant landmarks and I don't think we have to render toll roads in order to render the booths, I'm in favor of rendering them.

@sommerluk
Copy link
Collaborator

I would also render it.

Currently there is no special rendering for toll roads. But there are various other barrier=* tags that are currently rendered. So when are yet some other barriers that are rendered, and so IMHO it would be logical to render also barrier=toll_booth.

@kocio-pl

Maybe some kind of tickets or car near the wall or car under the lift gate

I like this idea. Maybe in conjunction with some symbol for money?

@vbertola
Copy link

I would really like to add a comment in favour of rendering toll booths in some clear way, especially because you're not rendering toll roads. In Italy, some motorways are free, others are paid with a "closed" system (i.e. a toll booth on every entrance/exit), others are "open" i.e. you only pay when you encounter a toll booth in the middle of the motorway, so some stretches are free and others are not. For this latter type of roads, knowing at a glance where the toll booth is really makes a difference, because most people choose their routes so to avoid the paid stretches if they can. For this reason, all Italian road atlases traditionally have a specific, well prominent symbol for toll booths, and OSM is really at a disadvantage on this.

@kocio-pl
Copy link
Collaborator

Could you provide the 14px icon for this?

@vbertola
Copy link

There already are proposed icons here:
http://wiki.openstreetmap.org/wiki/Tag:barrier%3Dtoll_booth
The first one in particular looks good (though I'd rather have the € symbol in Europe instead of $, but I don't know if it's possible to change the icon according to the geographic area - in that case I'd be happy to make a € version of the icon).

@pnorman
Copy link
Collaborator

pnorman commented Sep 18, 2017

The first one in particular looks good

It's over 14x14. We also try to have our symbols region-agnostic.

@vbertola
Copy link

Ok, let me work on this, I assume that the guidelines are the ones listed here:
http://wiki.openstreetmap.org/wiki/Map_Icons#Standard_tile_layer_.28openstreetmap-carto.29
Should it be light blue (like bus stops, parkings etc) or grey (like traffic lights, gates etc)?

@kocio-pl
Copy link
Collaborator

I'm reopening, since you're ready to try.

I was thinking about colors (also brown), but have no conclusion yet, so we could just check them when a shape is more or less ready.

More detailed icon guidelines are here:
https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#map-icon-guidelines

@kocio-pl kocio-pl reopened this Sep 18, 2017
@pnorman
Copy link
Collaborator

pnorman commented Sep 18, 2017

Ok, let me work on this, I assume that the guidelines are the ones listed here:

Our guidelines are at https://github.com/gravitystorm/openstreetmap-carto/blob/master/CONTRIBUTING.md#map-icon-guidelines. Any other page is not official.

@matthijsmelissen
Copy link
Collaborator

To avoid confusion and duplication of information, I replaced the info on the wiki by a Github link.

@kocio-pl
Copy link
Collaborator

What about using lift gate icon, but blue (or brown) - not black as the other barriers? It could be enough to know that this is not ordinary gate.

@sommerluk
Copy link
Collaborator

Sound good to me.

@kocio-pl
Copy link
Collaborator

Preview of A2 toll booths in Poland using lift-gate-14.svg (standard gate icon is visible nearby):

z16
xbux3al

z17
sdifhan4

z18
xucbqcyz

z19
quflbs0m

The same with lift-gate-10.svg:

z16
0eenkyil

z17
er2agdl

z18
ypqhok1u

z19
qmcjl1wr

And with our standard liftgate.svg icon:

z16
qvumrk3h

z17
c9dfgnnf

z18
jeceqsws

z19
qxqtk9ii

@ghost
Copy link

ghost commented Oct 2, 2017

I've got another suggestion:

https://wiki.openstreetmap.org/w/images/0/08/Tollbox.svg

To be seen here in different sizes:

https://wiki.openstreetmap.org/wiki/User:MeastroGlanz

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 2, 2017

Could you make rendering test? The code is here, you just need to replace toll_booth.svg: https://github.com/kocio-pl/openstreetmap-carto/tree/toll

@vbertola
Copy link

vbertola commented Oct 2, 2017

Thanks for the work, I have been traveling a lot and did not have time to work on this. But any icon more or less is fine - I'd be interested in how it shows up at geographical scale, though. In Italy, toll booths are being mapped not as individual gates but as a single node per each direction:

https://www.openstreetmap.org/node/2542231532
http://www.openstreetmap.org/node/936954809

So one would really like the "toll booth" symbol to appear (once) even at a very high scale, e.g.:

https://www.openstreetmap.org/node/2542231532#map=14/45.3493/9.3090

I don't know how this is made, i.e. how is the renderer going to decide which elements are shown at higher scales and which are not.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 2, 2017

The renderer decides which one of a few POIs will be rendered if there's a place only for one, but if there are no other obstacles, it will show it as early as we decide, so don't worry.

The question is however from which initial zoom level they should start appearing. What do you think about it?

@vbertola
Copy link

vbertola commented Oct 3, 2017

In Italy, motorway junction names start appearing at 12x, doing the same would be a good choice (if possible, the toll booth name could be shown as well near the icon, however that is not as essential as for junctions).

@ghost
Copy link

ghost commented Oct 3, 2017

@kocio-pl Not really or not right now. I'm still getting into creating maps from data. So this may take a while.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 3, 2017

OK, just tell me if you will need some help. I guess this discussion goes quite well, so we can wait a bit longer with a final solution.

@kocio-pl
Copy link
Collaborator

Any news here?

@ghost
Copy link

ghost commented Dec 31, 2017

I fail to create maps. So no so far.

@sommerluk
Copy link
Collaborator

I still think this feature would be important to render.

Indeed, the proposal by @kocio-pl to use a barrier icon in blue is reasonable.

I’ve tried to combine some symbol for money (banknotes and coins like https://commons.wikimedia.org/wiki/File:Zeichen_391_-_Mautpflichtige_Strecke,_StVO_2003.svg) with a barrier, but it doesn’t work on a 14×14 icon. Even when using only banknotes and coins without a barrier, it doesn’t work – simply not enough space.

Other icon sets often use one of these:

  • A barrier combined with a dollar sign. This idea to use a dollar-sign is not region-agnostic. There exists a generic currency symbol (U+00A4 ¤ CURRENCY SIGN) but likely post people won’t recognize it, so that’s not a good option either.
  • A completely abstract shape (like a circle or a square). That would not be so nice for openstreetmap-carto as we are a quite feature-rich map yet.
  • Just a barrier icon. I think that’s also the best option for us.

About the rendering examples of @kocio-pl: The lift-gate-14.svg icon is difficult to recognize for me. I would prefer the versin with liftgate.svg or – to make it even more clear and also different from our standard barrier icon – something like bitmap which I could provide as pixel-aligned SVG if desired.

@SomeoneElseOSM
Copy link
Contributor

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 5, 2018

@sommerluk:

I still think this feature would be important to render.

I'm just waiting for a code ready to be merged. Currently I like the @MaestroGlanz design the most (#958 (comment)), but it hasn't been tested yet:

https://wiki.openstreetmap.org/wiki/File:Tollbox.svg

Do you want to test it and make the PR?

@vbertola
Copy link

vbertola commented Jan 7, 2018

Sorry for not having been able to work on this. But I also think that the booth + barrier design, without money symbols, is the most neutral option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants