Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for shop=trade (and potentially shop=wholesale) #3291

Closed
lakedistrictOSM opened this issue Jul 3, 2018 · 8 comments · Fixed by #3361
Closed

Add icon for shop=trade (and potentially shop=wholesale) #3291

lakedistrictOSM opened this issue Jul 3, 2018 · 8 comments · Fixed by #3361

Comments

@lakedistrictOSM
Copy link

https://wiki.openstreetmap.org/wiki/Tag:shop=trade
6.7k uses

Probably something involving pallets or maybe a fork lift truck. Could share an icon with shop=wholesale (1.3k uses).

1 trade01png

@Tomasz-W
Copy link

Tomasz-W commented Jul 3, 2018

I think it's too "wide" tag for specific icon. I would left dot-rendering only.

@Adamant36
Copy link
Contributor

Adamant36 commented Jul 3, 2018

@Tomasz-W maybe not in combination with its sub tags

trade=building_supplies: 1263, could be a stack of wood pallets
trade=plumbing: 176, probably not worth as icon showing yet
trade=timber: 122, could have same icon as building_supplies or just stay a dot for now
trade=agricultural_supplies: 380, a bag of seeds or a rake maybe
trade=tiles: 89, not worth showing yet and can keep as dot
trade=windows: 14, not worth showing yet

Building supplies seems way worth having an icon. Agricultural stores also. Some good examples of possible icons for both on Noun Project. The rest can probably just wait and stay as dots until their numbers increase.

@matkoniecz matkoniecz changed the title Add icon for shop=trade Add special icon for shop=trade Jul 4, 2018
@Tomasz-W
Copy link

Tomasz-W commented Jul 5, 2018

Icon proposals:

  • shop trade2 (3 boxes)
  • shop trade (4 boxes)

@kocio-pl kocio-pl added this to the New features milestone Jul 10, 2018
@Tomasz-W
Copy link

@kocio-pl
Copy link
Collaborator

I would use 3 boxes.

@lakedistrictOSM
Copy link
Author

@Tomasz-W
Copy link

Tomasz-W commented Jul 12, 2018

@lakedistrictOSM I prefer my version, because it has adhesive tape shapes making the squares look more like a boxes.

@lakedistrictOSM
Copy link
Author

@Tomasz-W I like the detail on your version but it looks a bit blurry to me. In any case it should be 3 boxes, since 4 boxes is too solid.

@lakedistrictOSM lakedistrictOSM changed the title Add special icon for shop=trade Add icon for shop=trade (and potentially shop=wholesale) Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants