-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise plot lines #234
Optimise plot lines #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (5)
src/YagrCore/plugins/plotLines/plotLines.ts:19
- The comment contains a grammatical error. It should be corrected to: /** This code handles unexpected Infinities in values */
/** This weird code should handles unexpected Inifinities in values */
src/YagrCore/plugins/plotLines/plotLines.ts:166
- Ensure that the new method addPlotLines is covered by tests.
function addPlotLines(additionalPlotLines: PlotLineConfig[]) {
src/YagrCore/plugins/plotLines/plotLines.ts:176
- Ensure that the new method removePlotLines is covered by tests.
function removePlotLines(plotLinesToRemove: PlotLineConfig[], scale?: string | undefined) {
src/YagrCore/plugins/plotLines/plotLines.ts:186
- Ensure that the new method updatePlotLines is covered by tests.
function updatePlotLines(newPlotLines?: PlotLineConfig[] | undefined, scale?: string | undefined) {
src/YagrCore/plugins/plotLines/plotLines.ts:207
- Ensure that the new method clearPlotLines is covered by tests.
function clearPlotLines(scale?: string) {
e3d8b2e
to
e80c0a5
Compare
This PR refactors the plotLinesPlugin to improve performance.
Key improvements: