feat: add Trino column suggestions #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaShkaruba
commented
Jan 30, 2025
| "test:yql": "node --experimental-vm-modules ./node_modules/.bin/jest --testPathIgnorePatterns tests/generated/.+ --verbose src/autocomplete/databases/yql/tests/", | ||
| "test:redis": "node --experimental-vm-modules ./node_modules/.bin/jest --testPathIgnorePatterns tests/generated/.+ --verbose src/autocomplete/databases/redis/tests/", | ||
| "test:trino": "node --experimental-vm-modules ./node_modules/.bin/jest --testPathIgnorePatterns tests/generated/.+ --verbose src/autocomplete/databases/trino/tests/", | ||
| "test:mongo": "node --experimental-vm-modules ./node_modules/.bin/jest --testPathIgnorePatterns tests/generated/.+ --verbose src/autocomplete/databases/mongo/tests/", |
There was a problem hiding this comment.
We'll have less parameters this way, much easier to modify
| WHERE_ where = booleanExpression | ||
| )? # update | ||
| | MERGE_ INTO_ tableIdentifier (AS_? identifier)? USING_ relation ON_ expression mergeCase+ # merge | ||
| )? |
There was a problem hiding this comment.
I need these statements separate, to be able to run my visitor on them
| WHERE_ where = booleanExpression | ||
| )? (GROUP_ BY_ groupBy)? (HAVING_ having = booleanExpression)? ( | ||
| WINDOW_ windowDefinition (COMMA_ windowDefinition)* | ||
| )? | ||
| ; | ||
|
|
||
| fromClause | ||
| : FROM_ relation (COMMA_ relation)* | ||
| ; |
There was a problem hiding this comment.
Same as with insertStatement, I need to be able to run my visior on fromClause
| : patternRecognition (TABLESAMPLE_ sampleType LPAREN_ percentage = expression RPAREN_)? | ||
| | tableIdentifier | ||
| : tableReference | ||
| | patternRecognition (TABLESAMPLE_ sampleType LPAREN_ percentage = expression RPAREN_)? |
There was a problem hiding this comment.
They need to be reversed, because patterRecognition can include almost anything, and we want to have tableReference in a priority
| @@ -20,8 +20,6 @@ export interface TrinoAutocompleteResult extends SqlAutocompleteResult { | |||
| // TODO-TRINO: enrich autocomplete | |||
| suggestAggregateFunctions?: undefined; | |||
| suggestFunctions?: undefined; | |||
| suggestColumns?: undefined; | |||
| suggestColumnAliases?: undefined; | |||
There was a problem hiding this comment.
We properly support them now! :)
roberthovsepyan
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.