feat: support group in widget item #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
jhoncool
reviewed
Mar 7, 2024
src/utils/update-manager.ts
Outdated
| itemIds = [id].concat(item.data.tabs.map((tab) => tab.id)); | ||
| } | ||
| if (isItemWithGroup(item)) { | ||
| itemIds = [id].concat(item.data.group.map((tab) => tab.id)); |
src/shared/modules/helpers.ts
Outdated
| config: Config; | ||
| itemsStateAndParams: ItemsStateAndParams; | ||
| } | ||
|
|
||
| function getActualItems(items: ConfigItem[]) { |
There was a problem hiding this comment.
here u receive items ids - not items
maybe rename like getActualItemsIds?
| }).toEqual(addToQueue({id: DEFAULT_CONTROL_ID, config, itemsStateAndParams})); | ||
| }); | ||
|
|
||
| it('remove unused items from queue after adding new item', () => { |
There was a problem hiding this comment.
Can u add case where we have 1 items with 2 different groups in queue but one group id doesn't exist in the config? And we add something to queue - it should delete this group id from queue
src/utils/update-manager.ts
Outdated
| @@ -392,6 +531,7 @@ export class UpdateManager { | |||
| const newTabId: string | undefined = stateAndParams.state?.tabId; | |||
| const isTabSwitched = isItemWithTabs(initiatorItem) && Boolean(newTabId); | |||
| const currentMeta = getItemsStateAndParamsMeta(itemsStateAndParams); | |||
| const groupItemId = options?.groupItemId; | |||
There was a problem hiding this comment.
What if we add options.groupItemsIds instead of options.groupItemId?
Maybe sometimes you don't need update all groups in queue or you want to control order in queue for update all groups.
jhoncool
approved these changes
Mar 7, 2024
Marginy605
approved these changes
Mar 7, 2024
mournfulCoroner
added a commit
that referenced
this pull request
Mar 7, 2024
* feat: support group in widget item * chore: add tests * fix: review issues
mournfulCoroner
added a commit
that referenced
this pull request
Mar 7, 2024
* feat: support group in widget item * chore: add tests * fix: review issues
mournfulCoroner
added a commit
that referenced
this pull request
Mar 7, 2024
* feat: support group in widget item * chore: add tests * fix: review issues
mournfulCoroner
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for plugins that include a group of items. Each of the items should affect the state as if it were an independent element, but still be part of the same widget
The changes include edits in the setItem, the formation of queues and a state, the addition of a method
addGroupToQueueIn
onStateAndParamsChangethere's need to putgroupItemsIdsin options for correct work