feat/loading shimmer #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NikitaCG
commented
May 17, 2023
•
NikitaCG
commented
- add load shimmer
- refactor feed component logic
- fix mocks data for story
|
Preview is ready. |
src/blocks/Feed/Feed.tsx
Outdated
| handleChangeQueryParams({page: value}); | ||
| }; | ||
| if (hasFirstPageQuery) { | ||
| // eslint-disable-next-line no-not-accumulator-reassign/no-not-accumulator-reassign |
There was a problem hiding this comment.
Can you write it without eslint disable?
| /** | ||
| * @deprecated Metrika will be deleted after launch of analyticsEvents | ||
| */ | ||
| metrika.reachGoal(MetrikaCounter.CrossSite, BlogMetrikaGoalIds.showMore); | ||
| handleAnalytics(); | ||
|
|
||
| const nextPage = currentPage + 1; |
There was a problem hiding this comment.
Suggested change
| const nextPage = currentPage + 1; | |
| const nextPage = currentPage++; |
There was a problem hiding this comment.
currentPage is a variable from reducer, we cannot change this with ++.
we set currentPage in https://github.com/gravity-ui/blog-constructor/pull/50/files/7682f1b4830806edc1899ab1bbea16f03443254e#diff-7259b0c4587b3a60e4fb59ad5d1d5176d139f9f5c480c7025aec7d6c31999bfdR188 line
niktverd
reviewed
May 18, 2023
niktverd
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.