fix: semantic markup (#71)

* fix: semantic markup * fix: update package-lock
gravity-ui · Jun 23, 2023 · fb18afd · fb18afd
1 parent 78a4a5d
commit fb18afd
Show file tree

Hide file tree

Showing 5 changed files with 129 additions and 39 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -73,7 +73,7 @@
     "@commitlint/config-conventional": "^17.4.3",
     "@doc-tools/transform": "^2.9.0",
     "@gravity-ui/eslint-config": "^2.0.0",
-    "@gravity-ui/page-constructor": "^3.1.1",
+    "@gravity-ui/page-constructor": "^3.8.1",
     "@gravity-ui/prettier-config": "^1.0.1",
     "@gravity-ui/stylelint-config": "^1.0.0",
     "@gravity-ui/tsconfig": "^1.0.0",

diff --git a/src/components/PostInfo/components/Sharing.tsx b/src/components/PostInfo/components/Sharing.tsx
@@ -44,7 +44,7 @@ export const Sharing: React.FC<SharingProps> = ({theme, metrikaGoal}) => {
 
     return (
         <div className={b('item')}>
-            <span className={b('icon')}>
+            <div className={b('icon')}>
                 <SharePopover
                     url={getAbsolutePath(router)}
                     className={b('share')}
@@ -60,7 +60,7 @@ export const Sharing: React.FC<SharingProps> = ({theme, metrikaGoal}) => {
                     shareOptions={shareOptions}
                     handleMetrika={handleAnalytics}
                 />
-            </span>
+            </div>
         </div>
     );
 };
diff --git a/src/containers/BlogPage/BlogPage.tsx b/src/containers/BlogPage/BlogPage.tsx
@@ -1,4 +1,4 @@
-import React, {SyntheticEvent, useMemo} from 'react';
+import React, {Fragment, SyntheticEvent, useMemo} from 'react';
 
 import {
     NavigationData,
@@ -67,7 +67,7 @@ export const BlogPage = ({
     );
 
     return (
-        <main>
+        <Fragment>
             <LikesContext.Provider value={likes}>
                 <FeedContext.Provider
                     value={{
@@ -91,6 +91,6 @@ export const BlogPage = ({
                 </FeedContext.Provider>
             </LikesContext.Provider>
             <PromptSignIn {...promptSignInProps} />
-        </main>
+        </Fragment>
     );
 };
diff --git a/src/containers/BlogPostPage/BlogPostPage.tsx b/src/containers/BlogPostPage/BlogPostPage.tsx
@@ -51,37 +51,35 @@ export const BlogPostPage: React.FC<BlogPostPageProps> = ({
     });
 
     return (
-        <main>
-            <LikesContext.Provider
+        <LikesContext.Provider
+            value={{
+                toggleLike: likes?.toggleLike,
+                hasLikes: Boolean(likes),
+            }}
+        >
+            <PostPageContext.Provider
                 value={{
-                    toggleLike: likes?.toggleLike,
-                    hasLikes: Boolean(likes),
+                    post,
+                    suggestedPosts,
+                    likes: likes
+                        ? {
+                              handleUserLike: handleLike,
+                              hasUserLike,
+                              likesCount,
+                          }
+                        : undefined,
+                    shareOptions,
                 }}
             >
-                <PostPageContext.Provider
-                    value={{
-                        post,
-                        suggestedPosts,
-                        likes: likes
-                            ? {
-                                  handleUserLike: handleLike,
-                                  hasUserLike,
-                                  likesCount,
-                              }
-                            : undefined,
-                        shareOptions,
-                    }}
-                >
-                    <PageConstructorProvider {...settings}>
-                        {metaData ? <MetaWrapper {...metaData} /> : null}
-                        <PageConstructor
-                            content={content}
-                            custom={componentMap}
-                            navigation={navigation}
-                        />
-                    </PageConstructorProvider>
-                </PostPageContext.Provider>
-            </LikesContext.Provider>
-        </main>
+                <PageConstructorProvider {...settings}>
+                    {metaData ? <MetaWrapper {...metaData} /> : null}
+                    <PageConstructor
+                        content={content}
+                        custom={componentMap}
+                        navigation={navigation}
+                    />
+                </PageConstructorProvider>
+            </PostPageContext.Provider>
+        </LikesContext.Provider>
     );
 };