Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @babel/plugin-transform-class-properties to workaround bug in Safari 15 #91

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

melikhov-dev
Copy link
Contributor

@melikhov-dev melikhov-dev commented Oct 28, 2023

Safari 15 has a bug in class fields implementation.
see babel/babel#14289

Workaround: add @babel/plugin-proposal-class-properties to plugins.

@melikhov-dev melikhov-dev marked this pull request as ready for review October 28, 2023 19:32
@melikhov-dev melikhov-dev requested a review from ValeraS October 28, 2023 19:33
package.json Outdated
@@ -60,6 +60,7 @@
"@aws-sdk/client-s3": "^3.353.0",
"@babel/core": "^7.22.0",
"@babel/helper-plugin-utils": "^7.22.5",
"@babel/plugin-proposal-class-properties": "^7.18.6",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-transform-class-properties": "^7.22.5",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 5289c6a

@melikhov-dev melikhov-dev changed the title fix: add @babel/plugin-proposal-class-properties to workaround bug in Safari 15 fix: add @babel/plugin-transform-class-properties to workaround bug in Safari 15 Oct 31, 2023
@melikhov-dev melikhov-dev requested a review from ValeraS October 31, 2023 09:42
@ValeraS ValeraS merged commit c69b82e into main Oct 31, 2023
2 checks passed
@ValeraS ValeraS deleted the Add-babel-plugin-to-class-properties branch October 31, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants