Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Add two event codes for SSO test flow. #717

Merged
merged 5 commits into from
May 23, 2022
Merged

Add two event codes for SSO test flow. #717

merged 5 commits into from
May 23, 2022

Conversation

Tener
Copy link
Contributor

@Tener Tener commented Apr 4, 2022

Parent PR adding new event codes: gravitational/teleport#11508

This one will only get merged once the parent is in.

@Tener Tener requested review from kimlisa and smallinsky May 20, 2022 15:05
Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Tener! could you follow these steps (missing storybooking): #561

the exact files should be touched as seen in that PR, thanks

@Tener
Copy link
Contributor Author

Tener commented May 23, 2022

hi @Tener! could you follow these steps (missing storybooking): #561

the exact files should be touched as seen in that PR, thanks

Thanks, I'll follow that PR.

Any plans to automate this in the future?

@Tener Tener requested a review from kimlisa May 23, 2022 08:45
@Tener
Copy link
Contributor Author

Tener commented May 23, 2022

@kimlisa Done. PTAL?

@kimlisa
Copy link
Contributor

kimlisa commented May 23, 2022

Any plans to automate this in the future?

not that i know of, if there are thoughts to, then maybe after this repo gets merged into teleport (not sure what the status of that is)

@Tener Tener merged commit 6728547 into master May 23, 2022
@Tener Tener deleted the tener/tctl-sso branch May 23, 2022 16:27
Tener added a commit to gravitational/teleport that referenced this pull request May 24, 2022
67285475 Add two event codes for SSO test flow. (gravitational/webapps#717) gravitational/webapps@67285475

[source: -w master] [target: -t master]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants