Add alternate way to set clusterID #122
Conversation
| * getClusterIDFromURL solves empty clusterID result with Teleport | ||
| * Node's using versions < 4.3 (clusterId is not set for older versions). | ||
| */ | ||
| const getClusterIDFromURL = () => { |
There was a problem hiding this comment.
We cannot reach out to the browser URL from any place in the code and manually parse parameters. Normally you access the URL from UI layer (React components + React Router). If you look at how makeSession is invoke you will see that clusterID is coming from UI components where it already uses the clusterID to make a call to the web API.
That said, I now think that it's better to handle this use-case on the WebAPI layer. That would be a better place for the temporary fix as this is where missing id is coming from (this is not UI bug).
There was a problem hiding this comment.
created PR to apply patch on the web apiserver instead: gravitational/teleport#4027
|
created PR to apply patch on the web apiserver instead: gravitational/teleport#4027 |
fixes gravitational/teleport#4012
Description
Teleport node's running < v4.3 does not set clusterID for session info, which is needed to form session URL. This PR handles this incompatibility.
Manual Testing
Reproduced issue and tested with Proxy/Auth v4.3 with Node v4.2.11