Fixed scp regressions #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
approved these changes
Mar 29, 2017
|
Looks like the I was successfully able to run tests by appending |
In this commit: 1. Minor addition to Makefile to pull new .go files from tool/teleport/common 2. os.Glob() returns an empty list (instead of an error) if the file/pattern is not found, so added check for that. 3. sendFile was prematurely sending 'C' command before trying to open a file. This used to lead to creation of empty files for invlaid sources. Also, removed some confusing comments.
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #877.
Summary
Also, removed some confusing comments.
Issues
make teston OSX does not work for me and it's not related to this PR. This is what I see:not sure what "signal:killed" means.