-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Redshift IAM authentication #6479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
added
backport-required
database-access
Database access related issues and PRs
labels
Apr 16, 2021
awly
approved these changes
Apr 20, 2021
fspmarshall
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple minor nits. Looks good overall.
russjones
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for AWS Redshift IAM authentication to database access.
Redshift supports IAM authentication, but not in the same way as RDS/Aurora. There is a separate API to request Redshift IAM token, GetClusterCredentials. Other than that, Redshift speaks Postgres compatible protocol so
psql
works as usual, at least in my tests.Redshift requires one additional parameter in the config, cluster ID, so users would configure it like this (and database agent determines whether this is a Redshift database by the presence of this field):
The actual logic to generate Redshift auth token is actually very small and isolated in the same Auth interface that already generates tokens for RDS and Cloud SQL. But some extra related changes were required:
Fixes #6029 and needs backport to
v6
.