[vnet] remote app provider #51279
Merged
[vnet] remote app provider #51279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
force-pushed
the
nklaassen/remote-appprovider
branch
from
3d197ac to
7f8b0b3
Compare
nklaassen
added
no-changelog
nklaassen
force-pushed
the
nklaassen/remote-appprovider
branch
from
7f8b0b3 to
375602d
Compare
nklaassen
force-pushed
the
nklaassen/refactor-appprovider
branch
from
a3a4c20 to
53684bd
Compare
nklaassen
force-pushed
the
nklaassen/remote-appprovider
branch
from
5486ab6 to
a80b639
Compare
nklaassen
force-pushed
the
nklaassen/remote-appprovider
branch
from
a80b639 to
6086c59
Compare
ravicious
approved these changes
Jan 24, 2025
rosstimothy
reviewed
Jan 24, 2025
| mu sync.Mutex | ||
| // appSignerCache caches the crypto.Signer for each certificate issued by | ||
| // ReissueAppCert so that SignForApp can later use that signer. | ||
| appSignerCache map[appKey]crypto.Signer |
There was a problem hiding this comment.
What is the lifecycle for entries in the map?
There was a problem hiding this comment.
added a comment, we never need to evict signers because when the cert expires, ReissueAppCert will overwrite the signer with a new one. We currently never clean up stale app proxies that haven't been used for a while, one day we should probably do that to free up memory, at that point we should clean up the signers too
rosstimothy
approved these changes
Jan 28, 2025
nklaassen
force-pushed
the
nklaassen/remote-appprovider
branch
from
f34a5a6 to
7ad0064
Compare
public-teleport-github-review-bot
bot
removed the request for review
from GavinFrazar
|
@nklaassen See the table below for backport results.
|
nklaassen
added a commit
that referenced
this pull request
Jan 28, 2025
Backport #51279 to branch/v17
nklaassen
added a commit
that referenced
this pull request
Jan 29, 2025
Backport #51279 to branch/v17
nklaassen
added a commit
that referenced
this pull request
Jan 29, 2025
Backport #51279 to branch/v17
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
Backport #51279 to branch/v17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of RFD 195.
As a follow-up to #51216, this PR implements
vnet.remoteAppProviderwhich exposes apps to the VNet Windows admin service over gRPC. I'm also adding a unit test that asserts that networking works when apps are provided via the remote app provider.