Always collect metrics about top backend requests #4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
|
@klizhentas Any reason we might only want this available in debug mode? |
|
Chatted with @klizhentas, this can result in high memory usage on especially large clusters (with lots of nodes and/or remote clusters). |
Previously, it was only done in debug mode. This makes some tabs in `tctl top` empty, when auth server is not in debug mode.
awly
force-pushed
the
andrew/tctl-top-requests
branch
from
5f4f053 to
e589366
Compare
This LRU cache tracks the most frequent recent backend keys. All keys in this cache map to existing labels in the requests metric. Any evicted keys are also deleted from the metric. This will keep an upper limit on our memory usage while still always reporting the most active keys.
|
OK, added an LRU cache for the top requests alongside with the metric. On every cache eviction we'll delete the matching metric entry. PTAL |
fspmarshall
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was only done in debug mode. This makes some tabs in
tctl topempty, when auth server is not in debug mode.Fixes #4083