Remove blacklisted FIPS ciphersuites, fix local_auth #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes Web UI in FIPS mode when local_auth is false and removes two ciphers banned by HTTP2 rfc spec: https://tools.ietf.org/html/rfc7540#appendix-A and used by FIPS, causing Teleport GRPC to fail.
webvictim
reviewed
Oct 23, 2019
| tls.TLS_RSA_WITH_AES_128_GCM_SHA256, | ||
| tls.TLS_RSA_WITH_AES_256_GCM_SHA384, | ||
| // | ||
| // These two cipers suites: |
| @@ -308,6 +308,8 @@ func NewHandler(cfg Config, opts ...HandlerOption) (*RewritingHandler, error) { | |||
| if err == nil { | |||
| session.Session = base64.StdEncoding.EncodeToString(out) | |||
| } | |||
| } else { | |||
| log.WithError(err).Debugf("Could not authenticate.") | |||
There was a problem hiding this comment.
Don't we stipulate that error messages should be in lower case?
There was a problem hiding this comment.
this is not an error message though, it's a debug log entry that is a proper english sentence. Error is a WithError fileld
fspmarshall
approved these changes
Oct 23, 2019
russjones
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes Web UI in FIPS mode when local_auth is false
and removes two ciphers banned by HTTP2 rfc spec:
https://tools.ietf.org/html/rfc7540#appendix-A
and used by FIPS, causing Teleport GRPC to fail.