Fix memory leak. #2892
Merged
Fix memory leak. #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
reviewed
Aug 2, 2019
| c.Lock() | ||
| defer c.Unlock() | ||
| if watcher == nil { | ||
| c.Warningf("Internal logic error: %v.", trace.DebugReport(trace.BadParameter("empty watcher"))) |
There was a problem hiding this comment.
Not sure what trace.DebugReport(trace.BadParameter("empty watcher")) achieves here - looks like it'd be the same as just
c.Warning("Internal logic error: empty watcher")?
lib/backend/buffer.go
Outdated
| c.Warningf("Internal logic error: %v.", trace.DebugReport(trace.BadParameter("empty watcher"))) | ||
| return | ||
| } | ||
| log.Debugf("Removed watcher %p via external close.", watcher) |
lib/backend/buffer.go
Outdated
| // or asyncronously, used in prod, to avoid potential deadlocks | ||
| func (w *BufferWatcher) closeAndRemove(sync bool) error { | ||
| w.closeWatcher() | ||
| if removeSync { |
There was a problem hiding this comment.
This will always evaluate to true because removeSync is a constant defined above. Did you mean if sync here?
lib/backend/buffer.go
Outdated
| w.cancel() | ||
| return nil | ||
| } | ||
|
|
||
| const ( | ||
| removeSync = true | ||
| removeAsync = true |
There was a problem hiding this comment.
I'm guessing this should actually be false (judging by how it's used and the function below).
This commit fixes memory leak in the cache module: * Cache calls in to create a NewWatcher * NewWatcher gets registered in the backend * Cache closes the watcher * Watcher never gets deleted from the backend fanout internal structure. This is a defect in the way watchers are implemented: closing a watcher should result from it's removal from the fanout internal circular buffer prefix tree.
klizhentas
force-pushed
the
sasha/memleak
branch
from
c2382c8 to
55f5418
Compare
russjones
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes memory leak in the cache module:
fanout internal structure.
This is a defect in the way watchers are implemented:
closing a watcher should result from it's removal
from the fanout internal circular buffer prefix tree.