Fetch trusted CA from the main cluster. #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
approved these changes
Jan 16, 2019
klizhentas
force-pushed
the
sasha/fixlogin
branch
2 times, most recently
from
f115a8a to
d67e127
Compare
|
retest this please |
klizhentas
force-pushed
the
sasha/fixlogin
branch
from
d67e127 to
ec197f5
Compare
This PR fixes an issue with tsh login. Here is a flaw in logic described using the following scenario: Assume there are two clusters, 'main' and 'east'. 1. User logs into the first cluster 'main' 2. Selects the cluster 'east' in the profile 3. Next day, logs in again 4. Client pulls the trusted CA from the cluster 'main' as a part of SSH login procedure and adds to the keystore 5. Client connects to cluster 'east' because it is set as a current cluster in the profile 6. Client attempts to connect to the auth server of the cluster 'east' and fails because it does not trust the certificate of the 'east' yet, only 'main. This PR fixes the issue by making sure the client always connects to the cluster 'main' in the step 5 instead.
klizhentas
force-pushed
the
sasha/fixlogin
branch
from
ec197f5 to
e538c56
Compare
klizhentas
added a commit
that referenced
this pull request
Jan 17, 2019
This PR fixes an issue with tsh login. Here is a flaw in logic described using the following scenario: Assume there are two clusters, 'main' and 'east'. 1. User logs into the first cluster 'main' 2. Selects the cluster 'east' in the profile 3. Next day, logs in again 4. Client pulls the trusted CA from the cluster 'main' as a part of SSH login procedure and adds to the keystore 5. Client connects to cluster 'east' because it is set as a current cluster in the profile 6. Client attempts to connect to the auth server of the cluster 'east' and fails because it does not trust the certificate of the 'east' yet, only 'main. This PR fixes the issue by making sure the client always connects to the cluster 'main' in the step 5 instead.
klizhentas
added a commit
that referenced
this pull request
Jan 17, 2019
This PR fixes an issue with tsh login. Here is a flaw in logic described using the following scenario: Assume there are two clusters, 'main' and 'east'. 1. User logs into the first cluster 'main' 2. Selects the cluster 'east' in the profile 3. Next day, logs in again 4. Client pulls the trusted CA from the cluster 'main' as a part of SSH login procedure and adds to the keystore 5. Client connects to cluster 'east' because it is set as a current cluster in the profile 6. Client attempts to connect to the auth server of the cluster 'east' and fails because it does not trust the certificate of the 'east' yet, only 'main. This PR fixes the issue by making sure the client always connects to the cluster 'main' in the step 5 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with tsh login.
Here is a flaw in logic described using the following
scenario:
Assume there are two clusters, 'main' and 'east'.
as a part of SSH login procedure and adds to the keystore
set as a current cluster in the profile
'east' and fails because it does not trust the certificate
of the 'east' yet, only 'main.
This PR fixes the issue by making sure the client
always connects to the cluster 'main' in the step 5 instead.