tsh for Windows #2128
Merged
tsh for Windows #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/tsh-windows
branch
4 times, most recently
from
30c1675 to
7e83e6e
Compare
klizhentas
approved these changes
Aug 2, 2018
russjones
force-pushed
the
rjones/tsh-windows
branch
from
149f9e3 to
ec13acd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR builds upon #1996 submitted by @spectrumjade to add support for building tsh on Windows.
Implementation
tshon Windows always has a nil caching policy.ssh-agentare established over a Unix socket for Linux and macOS and a named pipe for Windows.ssh-agent. On Linux and macOS both certificate (with an embedded private key) and private key are loaded.tshis in debug mode, logs no longer go to syslog, instead go to stderr.ssh,join,play,scp, andbenchsubcommands are hidden on Windows.make release OS=windows.Related Issues
Fixes #2114
Fixes #1996