Remove DEBUG env var from Connect macOS dronegen #18899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was added in effort to debug flaky Connect builds (#15836). However, we discovered that the v11.1.0 macOS version of Connect stopped working. This was likely due to upgrade of electron-builder which recently updated its process of building native deps (electron-userland/electron-builder#7196). In the Node.js ecosystem, the DEBUG env var is typically used to control which packages emit debug messages [1]. However, after the update of electron-builder, the env var also changed the behavior of one of the packages responsible for building the apps. This was confirmed by inspecting file tree between different app bundles and running the build locally with DEBUG set to electron-*. [1] https://www.npmjs.com/package/debug
gzdunek
approved these changes
Nov 30, 2022
avatus
approved these changes
Nov 30, 2022
strideynet
approved these changes
Nov 30, 2022
|
Running a v11 drone build with this change included to be double sure that it fixes the problem. https://drone.platform.teleport.sh/gravitational/teleport/18079/26/1 |
|
idk if it's our macOS builder or Apple servers but notarizing the app bundles is super slow today. I'm yet to make a dev build because the notarization jobs time out after 1 hour. Since we're fairly confident that this is going to fix the problem and we reproduced the issue locally, I'm thinking of merging this straight away. Thoughts? @gzdunek @avatus |
|
I say ship it! |
|
There is an issue on the apple side https://developer.apple.com/system-status/
I agree, let's merge :) |
|
@ravicious See the table below for backport results.
|
ravicious
added a commit
that referenced
this pull request
Nov 30, 2022
It was added in effort to debug flaky Connect builds (#15836). However, we discovered that the v11.1.0 macOS version of Connect stopped working. This was likely due to upgrade of electron-builder which recently updated its process of building native deps (electron-userland/electron-builder#7196). In the Node.js ecosystem, the DEBUG env var is typically used to control which packages emit debug messages [1]. However, after the update of electron-builder, the env var also changed the behavior of one of the packages responsible for building the apps. This was confirmed by inspecting file tree between different app bundles and running the build locally with DEBUG set to electron-*. [1] https://www.npmjs.com/package/debug
|
I downloaded 11.1.1-dev.ravicious.3 and I can confirm that it works. |
ravicious
added a commit
that referenced
this pull request
Nov 30, 2022
It was added in effort to debug flaky Connect builds (#15836). However, we discovered that the v11.1.0 macOS version of Connect stopped working. This was likely due to upgrade of electron-builder which recently updated its process of building native deps (electron-userland/electron-builder#7196). In the Node.js ecosystem, the DEBUG env var is typically used to control which packages emit debug messages [1]. However, after the update of electron-builder, the env var also changed the behavior of one of the packages responsible for building the apps. This was confirmed by inspecting file tree between different app bundles and running the build locally with DEBUG set to electron-*. [1] https://www.npmjs.com/package/debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added in an effort to debug flaky Connect builds (#15836).
However, we discovered that the v11.1.0 macOS version of Connect stopped working. This was likely due to upgrade of electron-builder which recently updated its process of building native deps
(electron-userland/electron-builder#7196).
In the Node.js ecosystem, the DEBUG env var is typically used to control which packages emit debug messages [1]. However, after the update of electron-builder, the env var also changed the behavior of one of the packages responsible for building the apps.
This was confirmed by inspecting file tree between different app bundles and running the build locally with DEBUG set to electron-*.
[1] https://www.npmjs.com/package/debug
Although we did run a CI build after upgrading electron-builder to test if everything is working, we didn't actually execute the artifact built by drone, so we missed the fact that the build was broken.