[v9] Fix session tracker backwards compatibility. #12728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
application-access
audit-log
Joerger
changed the title
Joerger
force-pushed
the
joerger/fix-old-auth-prevents-session-tracking
branch
2 times, most recently
from
117c8f0 to
2840f3f
Compare
r0mant
reviewed
May 17, 2022
| // Ignore access denied errors, which we may get if the auth | ||
| // server is v9.2.1 or earlier, since only node, proxy, and | ||
| // kube roles had permission to create session trackers. | ||
| if !trace.IsAccessDenied(err) { |
There was a problem hiding this comment.
What happens if you get access denied and session tracker is not actually created? Will anything break down the road?
There was a problem hiding this comment.
In this case we are treating that access denied error as a not found error, which is expected since the server can't create/get session trackers. This essentially just maintains the old grace period logic for app, db, and desktop servers with a pre-v9.2.2 auth server.
r0mant
approved these changes
May 17, 2022
…s db, app, or windows desktop service. Add go.work files to .gitignore.
Joerger
force-pushed
the
joerger/fix-old-auth-prevents-session-tracking
branch
from
2840f3f to
84486f7
Compare
probakowski
approved these changes
May 17, 2022
|
|
||
| # Go workspace files | ||
| go.work | ||
| go.work.sum |
There was a problem hiding this comment.
Sorry I had auto-merge on 😅
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore access denied errors when creating/getting a session tracker as
db,app, orwindows desktopservice. This fixes compatibility with auth servers which are between v9.0.0 and v9.2.1, where access was only granted toproxy,kube, andnoderoles.This change does not need to be applied to master (v10)