[v9] Advertise correct MySQL server version #12340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teleport now will try to extract MySQL server version from initial handshake package instead of sending `8.0.0-Teleport` every time. This string can be overridden by new configuration option `mysql.server_version`. On DB service start Teleport will also try to fetch the current version from MySQL/MariaDB instance. After that the server version will be updated on every successful connection to keep it up to date. Co-authored-by: STeve (Xin) Huang <xin.huang@goteleport.com> Co-authored-by: Paul Gottschling <paul.gottschling@goteleport.com>
github-actions
bot
added
database-access
github-actions
bot
requested review from
greedy52,
marcoandredinis,
ptgott,
r0mant,
smallinsky,
timothyb89,
xinding33 and
zmb3
r0mant
approved these changes
Apr 29, 2022
russjones
approved these changes
Apr 30, 2022
Merged
marcoandredinis
approved these changes
May 2, 2022
greedy52
approved these changes
May 2, 2022
Remove `tsh` dependency on "github.com/gravitational/teleport/lib/srv/db/common" to fix WIndows build.
Co-authored-by: Marco André Dinis <marco.dinis@goteleport.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teleport now will try to extract MySQL server version from initial handshake package instead of sending
8.0.0-Teleportevery time. This string can be overridden by new configuration optionmysql.server_version. On DB service start Teleport will also try to fetch the current version from MySQL/MariaDB instance. After that the server version will be updated on every successful connection to keep it up to date.Co-authored-by: STeve (Xin) Huang xin.huang@goteleport.com
Co-authored-by: Paul Gottschling paul.gottschling@goteleport.com
Backport of #12196, #12344, #12347
TODO: