[v9] Backport Okta OIDC Fixes #11944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tener
reviewed
Apr 14, 2022
Tener
approved these changes
Apr 14, 2022
zmb3
force-pushed
the
v9-backport-11718
branch
2 times, most recently
from
6dd7fd7 to
5f93d97
Compare
smallinsky
reviewed
Apr 14, 2022
smallinsky
approved these changes
Apr 14, 2022
Closed
Using the OIDC connector with Okta would fail due to an issue in our fork of go-oidc. Update this dependency to get the fix. Additionally, clean up the logic for syncing the connector configuration, which was using a context.Context in order to implement a timeout. This can be expressed in a simpler way with time.After()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #11718