Removed unnecessary } in GraphQLEditor #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It took a while to track down but there is a closing curly bracket that's unnecessary. It gets rendered in output and it's visible on white background.
|
|
yoshiakis
reviewed
May 18, 2020
|
any update? |
7 tasks
EthanSK
approved these changes
May 28, 2020
|
This is such a small issue, but its implications are HUGE. How is an institution of any respectable capacity able to release something that looks so hideous into production? Can we please merge! |
|
@EthanSK hey there! this repository is under liminal maintenance as we transition before we archive and move to a new implementation. some months ago when we announced all of this, we asked users to identify which bugs were most important to fix before archiving. Prisma no longer maintains this repo. Please heed the warnings! |
acao
approved these changes
May 28, 2020
yoshiakis
referenced
this pull request
May 31, 2020
* refactor(graphql-playground-react): remove unused method * fix(graphql-playground-react): side tabs doesn't appear This commit fixes the following bug: side tabs doesn't appear when GraphQLEditor component isn't updated
|
@acao Where is the announcement about this? And also, when is the new implementation going to be released. Thanks |
abernix
pushed a commit
to apollographql/graphql-playground
that referenced
this pull request
Jan 29, 2021
It took a while to track down but there is a closing curly bracket that's unnecessary. It gets rendered in output and it's visible on white background.
abernix
pushed a commit
to apollographql/graphql-playground
that referenced
this pull request
Jan 29, 2021
It took a while to track down but there is a closing curly bracket that's unnecessary. It gets rendered in output and it's visible on white background.
cgxxv
pushed a commit
to cgxxv/graphql-playground
that referenced
this pull request
Mar 25, 2022
It took a while to track down but there is a closing curly bracket that's unnecessary. It gets rendered in output and it's visible on white background.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # N/A.
Changes proposed in this pull request:
It took a while to track down but there is a closing curly bracket that's unnecessary. It gets rendered in output and it's visible on white background. I removed it. This was introduced in #1001 https://github.com/prisma-labs/graphql-playground/pull/1001/files#diff-977e6e5ed829c1b17ed396af79ae26b3R291
Before
This is a screenshot from master
After
This is a screenshot from the Netlify preview app