perf: do not use undefined for empty error array #4469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
odd, reverting both changes singly seems fine, but when benchmarking together, reverting does have a small perf hit (on our synthetic microbenchmarks) |
yaacovCR
changed the title
going to retain just the changes to the errors array rather than to the incrementalDataRecords array. the fix in terms of the latter is really to remove the entire idea of the |
yaacovCR
force-pushed
the
do-not-use-undefined
branch
from
7440c61 to
88c48c9
Compare
|
yaacovCR
force-pushed
the
do-not-use-undefined
branch
from
dc41871 to
ef36972
Compare
yaacovCR
force-pushed
the
do-not-use-undefined
branch
from
ef36972 to
d33fcf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert previously attempted micro-optimization as it no longer produces (never produced?) a true performance benefit.