Skip to content

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Jun 2, 2023

to minimize later diffs, we can watch how the tests change, rather than simple introducing tons of new tests

depends on #3930

@netlify
Copy link

netlify bot commented Jun 2, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 233a96e
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/64decf943a5cb7000974a9e0
😎 Deploy Preview https://deploy-preview-3904--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR requested a review from robrichard June 2, 2023 11:09
@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Jun 2, 2023
@yaacovCR yaacovCR requested a review from a team June 2, 2023 11:09
@yaacovCR yaacovCR force-pushed the add-tests branch 10 times, most recently from b4fb3b9 to 9061654 Compare June 10, 2023 19:52
@yaacovCR yaacovCR force-pushed the add-tests branch 7 times, most recently from 9de10de to 77c1011 Compare July 6, 2023 02:06
@yaacovCR yaacovCR merged commit 75d419d into graphql:main Aug 18, 2023
@yaacovCR yaacovCR deleted the add-tests branch August 18, 2023 01:58
sakesun pushed a commit to sakesun/graphql-js that referenced this pull request Sep 1, 2023
to minimize later diffs, we can watch how the tests change, rather than
simple introducing tons of new tests

depends on graphql#3930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: polish 💅 PR doesn't change public API or any observed behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants