Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish: add additional test #3749

Merged
merged 1 commit into from
Sep 27, 2022
Merged

polish: add additional test #3749

merged 1 commit into from
Sep 27, 2022

Conversation

yaacovCR
Copy link
Contributor

note that filtering is still required for synchronous error bubbling with stream.

With defer, patches are not executed if the initial field set execution fails, but with stream, the initial items (perhaps of zero length) will execute and will create the stream record.

@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 6aa2f57
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/633356e2eca3c40009cf8afa
😎 Deploy Preview https://deploy-preview-3749--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 22, 2022
@yaacovCR yaacovCR requested review from robrichard, IvanGoncharov and a team September 22, 2022 23:09
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaacovCR ready to merge, but please fix prettier

note that filtering is still required for synchronous error bubbling with stream.

With defer, patches are not executed if the initial field set execution fails, but with stream, the initial items (perhaps of zero length) will execute and will create the stream record.
@yaacovCR yaacovCR merged commit bd5aae7 into graphql:main Sep 27, 2022
@yaacovCR yaacovCR deleted the add-more-tests branch September 27, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants