defer/stream: fix flattenAsyncIterable concurrency #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @glasser, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
glasser
force-pushed
the
glasser/defer-stream-fix-flattenAsyncIteratable
branch
from
af7e0a7 to
10a3b3e
Compare
robrichard
reviewed
Aug 19, 2022
| @@ -143,15 +120,20 @@ describe('flattenAsyncIterable', () => { | |||
| expect(caughtError).to.equal('ouch'); | |||
| }); | |||
| /* c8 ignore start */ | |||
There was a problem hiding this comment.
Can you remove the c8 ignore wrapping this test?
Fixes the bug demonstrated in graphql#3709 (which has already been incorporated into the defer-stream branch). This fix is extracted from graphql#3703, which also updates the typing and API around execute. This particular change doesn't affect the API, other than making the `subscribe` return type more honest, as its returned generator could yield AsyncExecutionResult before this change as well. (The reason the previous version built is because every ExecutionResult is actually an AsyncExecutionResult; fixing that fact is part of what graphql#3703 does.)
glasser
force-pushed
the
glasser/defer-stream-fix-flattenAsyncIteratable
branch
from
10a3b3e to
b3d4058
Compare
robrichard
pushed a commit
that referenced
this pull request
Aug 23, 2022
Fixes the bug demonstrated in #3709 (which has already been incorporated into the defer-stream branch). This fix is extracted from #3703, which also updates the typing and API around execute. This particular change doesn't affect the API, other than making the `subscribe` return type more honest, as its returned generator could yield AsyncExecutionResult before this change as well. (The reason the previous version built is because every ExecutionResult is actually an AsyncExecutionResult; fixing that fact is part of what #3703 does.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug demonstrated in #3709 (which has already been incorporated
into the defer-stream branch).
This fix is extracted from #3703, which also updates the typing and API
around execute. This particular change doesn't affect the API (other
than making the
subscribereturn type more honest, as its returnedgenerator could yield AsyncExecutionResult before this change as well).