ci: Add CodeQL analysis #3700
Merged
ci: Add CodeQL analysis #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
IvanGoncharov
force-pushed
the
pr_branch4
branch
5 times, most recently
from
365ac4d to
9d2713f
Compare
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 18, 2022
Extracted from graphql#3700 CodeQL correctly reported that we using user supplied data in our scripts that can lead to shell injection. Running those scripts on untrusted PRs both locally and on CI can be problematic Note I reviewed all places and none of them can be exploited but it good practice to switch to spawnSync if we can. Aditional benefit it automatically solves all the issues with command arguments being misenterpritade by the shell.
IvanGoncharov
force-pushed
the
pr_branch4
branch
from
9d2713f to
2e5d18e
Compare
IvanGoncharov
added a commit
to IvanGoncharov/graphql-js
that referenced
this pull request
Aug 21, 2022
Extracted from graphql#3700 CodeQL correctly reported that we using user supplied data in our scripts that can lead to shell injection. Running those scripts on untrusted PRs both locally and on CI can be problematic Note I reviewed all places and none of them can be exploited but it good practice to switch to spawnSync if we can. Aditional benefit it automatically solves all the issues with command arguments being misenterpritade by the shell.
Motivation: codeql are quite popular now, moreover various projects use it as metric on how secure certain OSS project is. Example: https://github.com/ ossf/scorecard/blob/main/docs/checks.md#sast Also, it can uncover some real security issues both in our sorce code and GitHub workflows. So I don't see a lot of harm by enabling it, we can always ignore certain files or disable it completely. Fixes graphql#3162
IvanGoncharov
force-pushed
the
pr_branch4
branch
from
2e5d18e to
6e7090e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: codeql are quite popular now, moreover various projects use it
as metric on how secure certain OSS project is. Example: https://github.com/
ossf/scorecard/blob/main/docs/checks.md#sast
Also, it can uncover some real security issues both in our sorce code and GitHub
workflows.
So I don't see a lot of harm by enabling it, we can always ignore certain files
or disable it completely.
Fixes #3162