Refactor GraphQL*Type TS types to be more DRY
#3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for compassionate-pike-271cb3 pending review.Visit the deploys page to approve it
|
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
added
the
PR: polish 💅
IvanGoncharov
approved these changes
May 19, 2022
There was a problem hiding this comment.
Adding a new type, were it ever to happen, would require fewer code changes.
I would say chances are close to zero. But who knows.
Overall I think it's an improvement.
P.S. "stacked" PRs are not mandatory if the overall size of PR is small like here. Just create separate commits and merge PR with "merge and rebase". One caveat, if you do that please don't do fix as separate commits (e.g. add tests, review fixes, improve coverage) please update commits directly using git rebase -i
Motivation: 1. Makes it easier to understand the type hierarchy. 2. Adding a new type, were it ever to happen, would require fewer code changes. Depends on graphql#3597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Depends on #3597